Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poetry requirement from <=1.2.0,>=1.1.15 to >=1.1.15,<1.3.0 in /python/helpers #5746

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2022

Updates the requirements on poetry to permit the latest version.

Release notes

Sourced from poetry's releases.

1.2.1

Changed

  • Bump poetry-core to 1.2.0.
  • Bump poetry-plugin-export to ^1.0.7.

Fixed

  • Fix an issue where poetry cache clear did not respect the -n/--no-interaction flag (#6338).
  • Fix an issue where poetry lock --no-update updated dependencies from non-PyPI package sources (#6335).
  • Fix a poetry install performance regression by falling back to internal pip (#6062).
  • Fix an issue where a virtual environment was created unnecessarily when running poetry export (#6282).
  • Fix an issue where poetry lock --no-update added duplicate hashes to the lock file (#6389).
  • Fix an issue where poetry install fails because of missing hashes for url dependencies (#6389).
  • Fix an issue where Poetry was not able to update pip in Windows virtual environments (#6430).
  • Fix an issue where Poetry was not able to install releases that contained less common link types (#5767).
  • Fix a poetry lock performance regression when checking non-PyPI sources for yanked versions (#6442).
  • Fix an issue where --no-cache was not respected when running poetry install (#6479).
  • Fix an issue where deprecation warnings for --dev were missing (#6475).
  • Fix an issue where Git dependencies failed to clone when insteadOf was used in .gitconfig using the Dulwich Git client (#6506).
  • Fix an issue where no cache entry is found when calling poetry cache clear with a non-normalized package name (#6537).
  • Fix an invalid virtualenv constraint on Poetry (#6402).
  • Fix outdated build system requirements for Poetry (#6509).

Docs

  • Add missing path segment to paths used by install.python-poetry.org (#6311).
  • Add recommendations about how to install Poetry in a CI environment (#6345).
  • Fix examples for --with and --without (#6318).
  • Update configuration folder path for macOS (#6395).
  • Improve the description of the virtualenv.create option (#6460).
  • Clarify that poetry install removes dependencies of non-installed extras (#6229).
  • Add a note about pre-commit autoupdate and Poetry's hooks (#6497).
Changelog

Sourced from poetry's changelog.

[1.2.1] - 2022-09-16

Changed

  • Bump poetry-core to 1.2.0.
  • Bump poetry-plugin-export to ^1.0.7.

Fixed

  • Fix an issue where poetry cache clear did not respect the -n/--no-interaction flag (#6338).
  • Fix an issue where poetry lock --no-update updated dependencies from non-PyPI package sources (#6335).
  • Fix a poetry install performance regression by falling back to internal pip (#6062).
  • Fix an issue where a virtual environment was created unnecessarily when running poetry export (#6282).
  • Fix an issue where poetry lock --no-update added duplicate hashes to the lock file (#6389).
  • Fix an issue where poetry install fails because of missing hashes for url dependencies (#6389).
  • Fix an issue where Poetry was not able to update pip in Windows virtual environments (#6430).
  • Fix an issue where Poetry was not able to install releases that contained less common link types (#5767).
  • Fix a poetry lock performance regression when checking non-PyPI sources for yanked versions (#6442).
  • Fix an issue where --no-cache was not respected when running poetry install (#6479).
  • Fix an issue where deprecation warnings for --dev were missing (#6475).
  • Fix an issue where Git dependencies failed to clone when insteadOf was used in .gitconfig using the Dulwich Git client (#6506).
  • Fix an issue where no cache entry is found when calling poetry cache clear with a non-normalized package name (#6537).
  • Fix an invalid virtualenv constraint on Poetry (#6402).
  • Fix outdated build system requirements for Poetry (#6509).

Docs

  • Add missing path segment to paths used by install.python-poetry.org (#6311).
  • Add recommendations about how to install Poetry in a CI environment (#6345).
  • Fix examples for --with and --without (#6318).
  • Update configuration folder path for macOS (#6395).
  • Improve the description of the virtualenv.create option (#6460).
  • Clarify that poetry install removes dependencies of non-installed extras (#6229).
  • Add a note about pre-commit autoupdate and Poetry's hooks (#6497).

[1.2.0] - 2022-08-31

Docs

  • Added note about how to add a git dependency with a subdirectory (#6218)
  • Fixed several style issues in the docs (#6255)
  • Fixed outdated info about --only parameter (#6264)

[1.2.0rc2] - 2022-08-26

Fixed

  • Fixed an issue where virtual environments were created unnecessarily when running poetry self commands (#6226)
  • Ensure that packages' pretty_name are written to the lock file (#6243)

... (truncated)

Commits
  • 7cd761a release: bump version to 1.2.1
  • f47f2aa fix(cache clear): normalize package name
  • fc4bc0c fix: wrong nested table level when overwriting pyproject (#6512)
  • f6cce31 build(deps): bump dulwich to 0.20.46
  • 3202859 fix: poetry-core>=1.1.0 is needed as build-system requirement
  • bacef6a [1.2] docs: added note about pre-commit autoupdate (#6502)
  • 5535e13 [1.2] Add missing deprecation warning for --dev (#6493)
  • 22741bb Clarify removal for non-installed extras & optional groups (#6229)
  • b5b7843 respect --no-cache at poetry install
  • 7d09bc5 [1.2] docs: improved description of virtualenvs.create option (#6469)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 19, 2022 06:00
@dependabot dependabot bot added dependencies python Dependabot pull requests that update Python code labels Sep 19, 2022
@dependabot dependabot bot force-pushed the dependabot/pip/python/helpers/poetry-gte-1.1.15-and-lt-1.3.0 branch from 67cd04c to 93f1f94 Compare September 19, 2022 18:24
@jeffwidman
Copy link
Member

Test failure: https://github.com/dependabot/dependabot-core/actions/runs/3084706530/jobs/4989361093

I can't quite figure out what that diff is trying to tell me, but given that a hash is shown in red, I suspect might be related to python-poetry/poetry#6389 in which case we just need to update expected test output.

However, I may be misunderstanding, as I've never really looked into how these smoke tests are generating expected vs actual, so will need to do a little more digging before proceeding...

@jakecoffman
Copy link
Member

If you look at the Diff step right after the failed one, it gives you another view of what has changed.

I have rerun with a new version of the CLI that fixes a minor issue, so that DIff step shows:

366d365
<                         {file = "toml-0.10.0-py2.[7](https://github.com/dependabot/dependabot-core/actions/runs/3084706530/jobs/4989361093#step:9:8).egg", hash = "sha256:f1db651f9657708513243e61e6cc67d101a39bad662eaa9b5546f789338e07a3"},

So that's saying this line has been removed due to the Poetry bump.

That looks like just a result of Poetry changing versions and not some other issue, so we'll need to update the test either before or after merge to remove that line to get the tests passing again.

@dependabot dependabot bot force-pushed the dependabot/pip/python/helpers/poetry-gte-1.1.15-and-lt-1.3.0 branch from 93f1f94 to 5dd99b1 Compare September 21, 2022 15:03
jeffwidman added a commit to dependabot/smoke-tests that referenced this pull request Sep 21, 2022
`poetry` `1.2.1` no longer generates this line that was present in `1.2.0`.

I'm not 100% positive, but I _think_ that might be the result of python-poetry/poetry#6389.

Details here: dependabot/dependabot-core#5746 (comment)
@jeffwidman
Copy link
Member

Merging this. I put up the test fix, but it's in a different repo so there's a two-step dance either way, and _jakecoffman wisely suggested merging here first and watching how it works in prod... so that if we need to rollback we only rollback in one repo and not two.

@dependabot dependabot bot force-pushed the dependabot/pip/python/helpers/poetry-gte-1.1.15-and-lt-1.3.0 branch from 5dd99b1 to 1cf4cd5 Compare September 21, 2022 19:52
@mctofu
Copy link
Contributor

mctofu commented Sep 21, 2022

@dependabot rebase

Updates the requirements on [poetry](https://github.com/python-poetry/poetry) to permit the latest version.
- [Release notes](https://github.com/python-poetry/poetry/releases)
- [Changelog](https://github.com/python-poetry/poetry/blob/master/CHANGELOG.md)
- [Commits](python-poetry/poetry@1.1.15...1.2.1)

---
updated-dependencies:
- dependency-name: poetry
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/python/helpers/poetry-gte-1.1.15-and-lt-1.3.0 branch from 1cf4cd5 to 3b79250 Compare September 21, 2022 22:37
@jeffwidman jeffwidman merged commit de7a116 into main Sep 21, 2022
@jeffwidman jeffwidman deleted the dependabot/pip/python/helpers/poetry-gte-1.1.15-and-lt-1.3.0 branch September 21, 2022 22:55
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies python Dependabot pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants