Fixes Alias parsing was not enabled issue while loading Psych Lib in safe_load #9759
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sachin-sandhu Is is possible to add a test case for this case? |
Hi @honeyankit , I have added test cases as following:
|
Adding new line at end of file
modified the YAML file contents
honeyankit
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue : #9505
Issue Description : Link to original issue Sentry issue .After Dependabot update #8854 , Psych library load started throwing exception Psych::AliasesNotEnabled Full detail . This is likely due to incompatibility between Ruby and psych https://bugs.ruby-lang.org/issues/17866 .
Resolution : : While enabling aliases: true is assumed safe, There is a small possibility to crash the function on certain YAML load ( link #5 ) . I propose to release the fix to stage environment and observe the fix for several days before merging to main branch.