Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade crack and http-party gems for ruby compatibility #9770

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Upgrade crack and http-party gems for ruby compatibility #9770

merged 8 commits into from
Jun 4, 2024

Conversation

smcavallo
Copy link
Contributor

Resolves the warnings:
bundle update crack to resolve:

gems/ruby-3.3.1/gems/crack-0.4.5/lib/crack/xml.rb:9: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of crack-0.4.5 to add bigdecimal into its gemspec.

bundle update httparty to resolve:

gems/ruby-3.3.1/gems/httparty-0.21.0/lib/httparty.rb:10: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.

@smcavallo smcavallo requested a review from a team as a code owner May 19, 2024 14:12
@smcavallo
Upgrade crack and http-party gems for ruby compatibility
9e508a8 
Signed-off-by: smcavallo <smcavallo@hotmail.com>
@smcavallo smcavallo requested a review from a team as a code owner May 24, 2024 19:37
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: devcontainers labels May 24, 2024
@JamieMagee
Copy link
Contributor

Thanks for the contribution.

Could you remove the .rbi files from /bin/sorbet/rbi/gems? They're only meant to be in /sorbet/rbi/gems.

@Adawntoremember
Copy link

Resolves the warnings:
bundle update crack to resolve:

gems/ruby-3.3.1/gems/crack-0.4.5/lib/crack/xml.rb:9: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of crack-0.4.5 to add bigdecimal into its gemspec.

bundle update httparty to resolve:

gems/ruby-3.3.1/gems/httparty-0.21.0/lib/httparty.rb:10: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.

@smcavallo
Copy link
Contributor Author

@JamieMagee @Adawntoremember - all set - I have removed the rbi files from bin
Please let me know if you'd like me to squash into a single commit

@JamieMagee JamieMagee mentioned this pull request Jun 4, 2024
Closed
5 tasks
@abdulapopoola abdulapopoola merged commit 5d1d1b5 into dependabot:main Jun 4, 2024
38 checks passed
@smcavallo smcavallo deleted the misc-gem-updates branch June 4, 2024 23:45
@deivid-rodriguez deivid-rodriguez mentioned this pull request Jun 5, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees
No one assigned
Labels
L: dart:pub Dart packages via pub L: devcontainers L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: terraform Terraform packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smcavallo @JamieMagee @Adawntoremember @abdulapopoola