refactor: compatibility with node.js 0.12 #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreialecu
force-pushed
the
refactor-node-0-12
branch
3 times, most recently
from
76db82e
to
ecfcde1
Compare
|
Ref for socket.io issue: socketio/socket.io#2056 |
|
Also note: the core of deployd itself was compatible, the main problems were in the tests/mock of timers and runtests.js for the integration tests AND the aforementioned socket.io version issue. |
Various changes to support node 0.12. Updated some dependencies. Socket.io has some issues with an outdated version of the `ws` package not building correctly on node 0.12 which is only in the master on git, so using that for now. Once they release to npm we can remove the pinned dependencies.
andreialecu
force-pushed
the
refactor-node-0-12
branch
from
ecfcde1
to
007138c
Compare
This was referenced May 25, 2015
|
Landed as 45d200e Thanks @andreialecu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to support node 0.12. Updated some dependencies.
Socket.io has some issues with an outdated version of the
wspackage not building correctly on node 0.12 which is only in the master on git, so using that for now. Once they release to npm we can remove the pinned dependencies.