Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

Integrate FidryCpuCoreCounter #4495

Merged

Conversation

theofidry
Copy link
Contributor

See theofidry/cpu-core-counter#11 for the motivations.

The code should be sensibly the same, the notable differences are:

  • fixed the deprecated usage of hw.ncpu
  • /proc/cpuinfo is check last
  • nproc is checked first (before was not checked at all, it's considered to be more accurate and less convoluted than cpuinfo though)

Also note since this was analogue to PHPStan, I did the PR there too: phpstan/phpstan-src#2047

I would also wait on 1.x before merging this if you're happy with it. Technically the current version is fine, I'm just looking for a round of feedback before publishing 1.0.

@TomasVotruba
Copy link
Member

The CI needs some fixing

@TomasVotruba
Copy link
Member

Thank you 👏

Let's try this out in the wild :)

@TomasVotruba TomasVotruba merged commit ca5093a into deprecated-packages:main Dec 11, 2022
@theofidry theofidry deleted the feature/cpu-core-counter branch December 11, 2022 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants