♻️ feat(api): add search term recommend #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seonghun-dev
commented
Sep 6, 2023
•
seonghun-dev
commented
- resolve : Create search term recommendation API #216
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #327 +/- ##
============================================
- Coverage 28.15% 27.59% -0.56%
Complexity 76 76
============================================
Files 45 47 +2
Lines 611 627 +16
Branches 18 18
============================================
+ Hits 172 173 +1
- Misses 437 452 +15
Partials 2 2
|
DongGeon0908
reviewed
Sep 6, 2023
There was a problem hiding this comment.
13기 프로젝트 보면서, 가장 인상 깊게 본 server-api인 것 같아요.
항상 응원하고, 염탐하고 있습니다. ㅎㅎ
화이팅~~~ cc. @yunyoung1819
...-api/src/main/java/com/depromeet/domains/recommend/controller/SearchRecommendController.java
Show resolved
Hide resolved
.../src/main/java/com/depromeet/domains/recommend/repository/SearchRecommendTermRepository.java
Show resolved
Hide resolved
backend/streetdrop-domain/src/main/java/com/depromeet/recommend/search/SearchRecommendTerm.java
Show resolved
Hide resolved
...etdrop-api/src/main/java/com/depromeet/domains/recommend/service/SearchRecommendService.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/com/depromeet/domains/recommend/search/service/SearchRecommendService.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/com/depromeet/domains/recommend/search/service/SearchRecommendService.java
Outdated
Show resolved
Hide resolved
|
@siyeonSon @yunyoung1819 |
yunyoung1819
reviewed
Oct 7, 2023
...drop-admin-server/src/main/java/com/depromeet/domains/recommend/search/dto/TextColorDto.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/com/depromeet/domains/recommend/search/service/SearchRecommendService.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/depromeet/domains/recommend/search/controller/SearchRecommendController.java
Show resolved
Hide resolved
.../src/main/java/com/depromeet/domains/recommend/repository/SearchRecommendTermRepository.java
Show resolved
Hide resolved
yunyoung1819
approved these changes
Oct 9, 2023
seonghun-dev
added a commit
that referenced
this pull request
Nov 8, 2023
* ♻️ feat(api): add search term recommend * ✨ feat(api) : add textcolor vo and dto * 🐛 fix(api) : add api to text color dto * ♻️ chore(admin): fix to var * ♻️ chore(admin): fix to builder pattern * ♻️ chore(admin): fix to protected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.