feat(puppeteer): support puppeteer v9 (#242)

Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
dequelabs · May 4, 2021 · 753a919 · 753a919
1 parent 4e8f7fe
commit 753a919
Show file tree

Hide file tree

Showing 4 changed files with 106 additions and 52 deletions.
diff --git a/packages/puppeteer/package-lock.json b/packages/puppeteer/package-lock.json
diff --git a/packages/puppeteer/package.json b/packages/puppeteer/package.json
@@ -34,18 +34,18 @@
     "express": "^4.16.4",
     "mocha": "^5.2.0",
     "nyc": "^14.1.1",
-    "puppeteer": "^5.3.1",
+    "puppeteer": "^9",
     "sinon": "^7.3.2",
     "source-map-support": "^0.5.9",
     "test-listen": "^1.1.0",
     "ts-node": "^8.3.0",
-    "typescript": "^3.1.6"
+    "typescript": "^4.2.4"
   },
   "dependencies": {
     "axe-core": "^4.2.0"
   },
   "peerDependencies": {
-    "puppeteer": ">=1.10.0 < 6"
+    "puppeteer": ">=1.10.0 < 9"
   },
   "engines": {
     "node": ">=6.4.0"

diff --git a/packages/puppeteer/src/axePuppeteer.ts b/packages/puppeteer/src/axePuppeteer.ts
@@ -17,10 +17,12 @@ interface IInjectAxeArgs {
   args?: any[];
 }
 
-function injectJSModule(frame: Frame): Promise<void> {
-  return frame.addScriptTag({
-    path: require.resolve('axe-core')
-  });
+function injectJSModule(frame: Frame): Promise<ElementHandle<Element> | void> {
+  return frame
+    .addScriptTag({
+      path: require.resolve('axe-core')
+    })
+    .then(() => undefined);
 }
 
 function injectJSSource(
@@ -56,7 +58,7 @@ async function injectJS(
     console.error(`Failed to inject axe-core into frame (${frame.url()})`);
   };
 
-  let injectP: Promise<void>;
+  let injectP: Promise<ElementHandle<Element> | void>;
   if (!source) {
     injectP = injectJSModule(frame);
   } else {

diff --git a/packages/puppeteer/src/browser.ts b/packages/puppeteer/src/browser.ts
@@ -23,7 +23,7 @@ export function pageIsLoaded(): boolean {
   return document.readyState === 'complete';
 }
 
-export function configureAxe(config?: Axe.Spec) {
+export function configureAxe(config?: Axe.Spec): void {
   if (config) {
     window.axe.configure(config);
   }