fix(puppeteer,playwright): wait for finishRun to complete before clos…

…ing the page (#496) Co-authored-by: jpveooys <66470099+jpveooys@users.noreply.github.com>
dequelabs · Apr 4, 2022 · 7dc6a03 · 7dc6a03
1 parent af77177
commit 7dc6a03
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -134,7 +134,9 @@ jobs:
       - restore_dependency_cache
       # Re-build packages, ensuring packages/webdriverjs/dist exists.
       - run: npx lerna run prepare
-      - run: npx browser-driver-manager@1.0.4 install chrome chromedriver
+      - run: cd packages/cli && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
+      # lerna link after installing the latest version of chromedriver, as we depend on webdriverJS
+      - run: cd packages/cli && npx lerna link
       - run: npm run coverage --prefix=packages/cli
 
   puppeteer:
@@ -143,15 +145,15 @@ jobs:
       - checkout
       - restore_dependency_cache
       - run: npm run build --prefix=packages/puppeteer
-      - run: npx browser-driver-manager@1.0.4 install chrome chromedriver
+      - run: cd packages/puppeteer && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
       - run: npm run coverage --prefix=packages/puppeteer
 
   webdriverjs:
     <<: *defaults
     steps:
       - checkout
       - restore_dependency_cache
-      - run: npx browser-driver-manager@1.0.4 install chrome chromedriver
+      - run: cd packages/webdriverjs && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
       - run: npm --prefix=packages/webdriverjs run build
       - run: npm run coverage --prefix=packages/webdriverjs
 
@@ -170,7 +172,7 @@ jobs:
     steps:
       - checkout
       - restore_dependency_cache
-      - run: npx browser-driver-manager@1.0.4 install chrome chromedriver
+      - run: cd packages/webdriverio && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
       - run: npm run coverage --prefix=packages/webdriverio
 
   reporter-earl:

diff --git a/packages/playwright/src/index.ts b/packages/playwright/src/index.ts
@@ -290,8 +290,8 @@ export default class AxeBuilder {
         partialResults,
         options
       })
-      .finally(() => {
-        blankPage.close();
+      .finally(async () => {
+        await blankPage.close();
       });
   }
 }
diff --git a/packages/puppeteer/src/axePuppeteer.ts b/packages/puppeteer/src/axePuppeteer.ts
@@ -280,8 +280,8 @@ export class AxePuppeteer {
         partialResults as JSONArray,
         axeOptions as JSONObject
       )
-      .finally(() => {
-        blankPage.close();
+      .finally(async () => {
+        await blankPage.close();
       });
   }