fix(cli): provide a more robust error message if analysis fails (#421)

dequelabs · Jan 11, 2022 · 9f1fa5d · 9f1fa5d
1 parent 4d09009
commit 9f1fa5d
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/packages/cli/src/bin/cli.test.ts b/packages/cli/src/bin/cli.test.ts
@@ -180,6 +180,33 @@ describe('cli', () => {
         'Violation of "marquee" with 1 occurrences!'
       );
     });
+
+    it('should throw error if CSS selector is not found', async () => {
+      const result = await runCLI(
+        `file://${SIMPLE_HTML_FILE}`,
+        '--include',
+        '#hazaar',
+        '--show-errors'
+      );
+
+      assert.include(
+        result.stderr,
+        'javascript error: No elements found for include in page Context'
+      );
+      assert.equal(result.exitCode, 1);
+    });
+
+    it('should throw error if invalid selector is provided', async () => {
+      const result = await runCLI(
+        `file://${SIMPLE_HTML_FILE}`,
+        '--include',
+        '#123',
+        '--show-errors'
+      );
+
+      assert.include(result.stderr, 'is not a valid selector');
+      assert.equal(result.exitCode, 1);
+    });
   });
 
   describe('--exclude', () => {
@@ -194,6 +221,18 @@ describe('cli', () => {
         'Violation of "marquee" with 1 occurrences!'
       );
     });
+
+    it('should throw error if invalid selector is provided', async () => {
+      const result = await runCLI(
+        `file://${SIMPLE_HTML_FILE}`,
+        '--exclude',
+        '#123',
+        '--show-errors'
+      );
+
+      assert.include(result.stderr, 'is not a valid selector');
+      assert.equal(result.exitCode, 1);
+    });
   });
 
   describe('--disable', () => {

diff --git a/packages/cli/src/bin/index.ts b/packages/cli/src/bin/index.ts
@@ -150,7 +150,7 @@ const cli = async (
     if (!showErrors) {
       console.error(error('An error occurred while testing this page.'));
     } else {
-      console.error(error('Error: %j \n $s'), e.message, e.stack);
+      console.error(error('Error: %s'), e);
     }
 
     console.error(