Skip to content

Commit

Permalink
feat(webdriverjs): upgrade to axe-core 4.3 (#312)
Browse files Browse the repository at this point in the history
* feat(webdriverjs): upgrade to axe-core 4.3

* chore: parallelise runPartial

* fix: properly run in parallel

* chore: fix silly prettier problem

* chore(cli): push test fix

* chore: cleanup

* chore: resolve feedback

* chore: address feedback

* chore: update tests

* chore: simplify the implementation

* chore: remove comment

* chore: private runFramePartial

* refactor(webdriverjs): make runPartialRecursive too long
  • Loading branch information
WilcoFiers committed Aug 11, 2021
1 parent df1bff7 commit b416e74
Show file tree
Hide file tree
Showing 28 changed files with 33,200 additions and 253 deletions.
3 changes: 2 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
packages/cli/src/testutils/*
packages/cli/src/**/**/*.test.ts
packages/cli/src/**/**/*.test.ts
packages/webdriverjs/src/test/fixtures/*
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ module.exports = {
],
rules: {
'@typescript-eslint/camelcase': 'off',
'@typescript-eslint/interface-name-prefix': 'off'
'@typescript-eslint/interface-name-prefix': 'off',
'@typescript-eslint/no-use-before-define': 'off'
},
settings: {
react: {
Expand Down
14 changes: 6 additions & 8 deletions packages/cli/src/lib/axe-test-urls.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,12 @@ describe('testPages', function () {
};

await testPages(['http://foo'], config);

assert.equal(asyncScripts.length, 2);
const [script] = asyncScripts;
assert.match(
script,
/script\.innerHTML\s*=[\s\S]*['"]document\.documentElement\.classList\.add\(['"]deque-axe-is-ready/
);

const script = asyncScripts.find(scr => {
return scr.match(
/script\.innerHTML\s*=[\s\S]*['"]document\.documentElement\.classList\.add\(['"]deque-axe-is-ready/
);
});
assert.isDefined(script);
assert.equal(waitCalls, 1);
});

Expand Down

0 comments on commit b416e74

Please sign in to comment.