feat(webdriverjs): upgrade to axe-core 4.3 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
force-pushed
the
selenium-shadowdom
branch
from
2643f22
to
d5fdb8c
Compare
WilcoFiers
force-pushed
the
selenium-shadowdom
branch
from
e91eb0b
to
3acd66f
Compare
WilcoFiers
commented
Aug 3, 2021
packages/webdriverjs/src/browser.ts
Outdated
Comment on lines
35
to
39
| return ( | ||
| window && | ||
| window.axe && | ||
| typeof window.axe.runPartial === 'function' | ||
| ) |
There was a problem hiding this comment.
Suggested change
| return ( | |
| window && | |
| window.axe && | |
| typeof window.axe.runPartial === 'function' | |
| ) | |
| return (typeof window.axe.runPartial === 'function') |
straker
previously requested changes
Aug 3, 2021
straker
approved these changes
Aug 4, 2021
straker
previously requested changes
Aug 4, 2021
straker
previously approved these changes
Aug 5, 2021
WilcoFiers
force-pushed
the
selenium-shadowdom
branch
from
0be3b5e
to
4fdcffa
Compare
|
So I am not a fan of the double function recursion. I find it confusing and hard to follow exactly how it works (such as error handling and what the final result is). However, I'd like to ask @nloding and @michael-siek for their opinion on the code since you two are the maintainers. If you find the approach acceptable I can approve the PR. |
|
I agree with @straker I think it would be easier to read with a single recursive function since a developer would have to go back and forth to get a full understanding of what is going on. |
|
I'm in agreement. Since we've learned that it's all synchronous regardless, it makes the code harder to follow and, IMO, is tech debt. |
straker
previously requested changes
Aug 9, 2021
straker
approved these changes
Aug 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.