chore(i18n): Update and correct Japanese translation #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove whitespaces between English words and Japanese characters as agreed previously: dequelabs#3319 rules/accesskeys: wording change rules/aria-focus-hidden: wording change rules/aria-input-field-name/help: wording change rules/aria-roledescription/help: wording change rules/aria-text/description: make the location of the double-quotes consistent with the original text. rules/aria-toggle-field-name/help: change wording rules/aria-tooltip-name/description: wording change rules/aria-treeitem-name/description: wording changes rules/blink/help: correct translation rules/color-contrast-enhanced: correct translation rules/color-contrast: correct translation rules/css-orientation-lock/help: wording change rules/definition-list/help: correct translation rules/duplicate-id-active: wording changes rules/duplicate-id-aria/description: wording change rules/focus-order-semantics: correct translation rules/form-field-multiple-labels/help: wording change rules/frame-focusable-content: correct translation rules/frame-tested/help: change wording rules/frame-title: correct translation rules/hidden-content* correct translation rules/identical-links-same-purpose: correct translation rules/label-title-only/description: correct translation rules/landmark-complementary-is-top-level/help: wording change rules/landmark-one-main/description: correct translation rules/landmark-unique/description: correct translation. rules/link-in-text-block: correct translation rules/meta-refresh-no-exceptions: correct translation rules/meta-refresh: correct translation rules/meta-viewport-large/help: correct translation rules/meta-viewport: correct translation rules/nested-interactive: correct translation rules/no-autoplay-audio/help: correct translation rules/p-as-heading: correct translation rules/presentation-role-conflict: correct translation rules/role-img-alt: correct translation rules/scrollable-region-focusable: correct translation rules/svg-img-alt/help: correct translation rules/tabindex/help: correct translation rules/table-duplicate-name: correct translation rules/table-fake-caption/help: correct translation rules/target-size/help: correct translation rules/td-has-header: correct translation rules/td-headers-attr: correct translation rules/th-has-data-cells: swap the content of help and description to be consistent with the original. checks/aria-allowed-attr/incomplete: correct translation checks/aria-allowed-role/{fail,incomplete: correct translation checks/aria-busy/fail: correct translation checks/aria-errormessage{pass,fail}: correct translation checks/aria-required-children/fail/unallowed: sync with the en version checks/aria-allowed-attr/incomplete: correct translation checks/deprecatedrole/pass: correct translation checks/has-global-aria-attribute: correct translation checks/color-contrast-enhanced/incomplete/pseudoContent: consistent wording with other phrases checks/color-contrast/incomplete/pseudoContent: consistent wording with other phrases checks/pseudoContent/pass: consistent wording with other phrases checks/link-in-text-block/incomplete/{default,bgColorContrast}: correct translation checks/accesskeys: correct translation checks/focusable-disabled: correct translation checks/focusable-modal-open: correct translation checks/focusable-not-tabbable: correct translation checks/landmark-is-top-level/fail: correct translation checks/page-has-main/pass: correct translation checks/alt-space-value/fail: correct translation checks/explicit-label: correct translation checks/help-same-as-label: correct translation checks/hidden-explicit-label: correct translation checks/multiple-label/fail: correct translation checks/landmark-is-unique/pass: correct translation checks/listitem/fail/roleNotValid: correct translation checks/only-dlitems: correct translation checks/only-listitems: correct translation checks/caption/incomplete: correct translation checks/no-autoplay-audio: correct translation checks/css-orientation-lock: correct translation checks/target-offset: correct translation checks/target-size: correct translation checks/header-present: correct translation checks/identical-links-same-purpose/incomplete: correct translation checks/identical-links-same-purpose: correct translation Make the translation of the oword "present" consistent throughout the file. checks/meta-refresh-no-exceptions/fail: correct translation checks/meta-refresh/fail: correct translation checks/p-as-heading/fail: correct translation checks/duplicate-id-aria: correct translation checks/duplicate-id: correct translation checks/button-has-visible-text/{pass,fail}: correct translation checks/has-alt: correct translation checks/important-letter-spacing: correct translation checks/important-line-height: correct translation checks/important-word-spacing: correct translation checks/non-empty-alt/pass: correct translation checks/non-empty-if-present: correct translation checks/non-empty-placeholder: correct translation checks/non-empty-title: correct translation checks/non-empty-value: correct translation checks/presentational-role: correct translation checks/svg-non-empty-title: correct translation checks/caption-faked/pass: typo fix failureSummary/incompleteFallbackMessage: correct translation Make the translation for "role attribute" consistent throughout the file. Add ja translation for checks/aria-conditional-attr
|
@kiyochika Could you review this one? |
Sync with the current develop branch.
WilcoFiers
reviewed
Aug 21, 2023
locales/ja.json
Outdated
Comment on lines
52
to
55
| "aria-prohibited-attr": { | ||
| "description": "Ensures ARIA attributes are not prohibited for an element's role", | ||
| "help": "Elements must only use permitted ARIA attributes" | ||
| }, |
There was a problem hiding this comment.
@ma10 Did you mean to leave these without a translation?
There was a problem hiding this comment.
No, it should be something that has been added to the base branch after my last update and I overlooked when I merged the base branch last time.
I'll try to work on that one as soon as I get a chance.
There was a problem hiding this comment.
Done with commit 1c2d669
WilcoFiers
requested changes
Aug 21, 2023
locales/ja.json
Outdated
Comment on lines
432
to
433
| "singular": "ARIAロール${data.values}はこの要素で許可されていないため、要素が表示されたときはARIAロールを削除する必要があります", | ||
| "plural": "ARIAロール${data.values}この要素に許可されていないため、要素が表示されたときはARIAロールを削除する必要があります" |
There was a problem hiding this comment.
Going off Google Translate, these look like they are the wrong way around. The singular one (meaning there is one attribute) is under "plural", whereas the plural one is under "singular". Should these be switched around:
Suggested change
| "singular": "ARIAロール${data.values}はこの要素で許可されていないため、要素が表示されたときはARIAロールを削除する必要があります", | |
| "plural": "ARIAロール${data.values}この要素に許可されていないため、要素が表示されたときはARIAロールを削除する必要があります" | |
| "singular": "ARIAロール${data.values}この要素に許可されていないため、要素が表示されたときはARIAロールを削除する必要があります", | |
| "plural": "ARIAロール${data.values}はこの要素で許可されていないため、要素が表示されたときはARIAロールを削除する必要があります" |
There was a problem hiding this comment.
In Japanese, many nouns don't have different forms for singular and plural (there are suffixes to indicate plural for certain nouns, but not for all nouns.)
This case is no exception and the singular and the plural should be the same.
While reviewing your suggestion, I found a typo, so I'll commit a fix.
There was a problem hiding this comment.
Done with the commit 141ba17
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…een singular and plural
…ional-attr, checks/braille-label-equivalent, and checks/braille-roledescription-equivalent
WilcoFiers
requested changes
Aug 22, 2023
locales/ja.json
Outdated
| "incomplete": "アクセシブルなテキストを算出することができません" | ||
| }, | ||
| "braille-roledescription-equivalent": { | ||
| "pass": "aria-brailleroledescriptionはアクセシブルなテキストがある要素に対して使用されています", |
There was a problem hiding this comment.
Just one more issue (my fault). Rest looks good.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…ne with the changes introduced by PR dequelabs#4133
|
|
WilcoFiers
approved these changes
Aug 29, 2023
|
Reviewed for security. |
WilcoFiers
changed the title
WilcoFiers
changed the title
|
@WilcoFiers I appreciate your time and effort for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Japanese translation based on the message catalog as of 2023-05-11.
While adding translation for newly added rule, I also reviewed the whole file, and correct the existing translations.