Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-allowed-attr): allow aria-required on role=slider #4034

Closed
wants to merge 2 commits into from

Conversation

straker
Copy link
Contributor

@straker straker commented May 23, 2023

Tested in VO/Safari, JAWS/Chrome, and NVDA/Firefox.

Closes: #4027

@straker straker requested a review from a team as a code owner May 23, 2023 15:08
@CLAassistant
Copy link

CLAassistant commented May 23, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ straker
❌ Steven Lambert


Steven Lambert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@straker
Copy link
Contributor Author

straker commented May 23, 2023

Going to open this again with the correct email for license.

@straker straker closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is aria-required on input with type="range" a critical issue?
2 participants