feat: initial release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
requested changes
Nov 26, 2019
There was a problem hiding this comment.
This is much easier to grok/understand! I'm super excited that you're building this out without coupling to frameworks/etc, and that it's so little code 💯
Let's make sure we've got tests which will "fail nicely" if the private stuff we're dependent on stops working as expected. Otherwise LGTM!
| const panel = await extensionPanelTarget.page() | ||
|
|
||
| // The extension panel should be the first embedded frame of the targeted page | ||
| const [panelFrame] = await panel.frames() |
There was a problem hiding this comment.
Should we validate that it's the "correct" frame?
stephenmathieson
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few more steps we probably want to take (license, where to publish) but this is the initial code for getting devtools contexts from within puppeteer.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)