Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if the Node already cordoned when executing Drain #2275

Merged
merged 2 commits into from Nov 10, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Nov 8, 2023

this PR fixes #2273.

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Thanks Jayson for looking into this!!

internal/dao/node.go Outdated Show resolved Hide resolved
@derailed derailed added the question Further information is requested label Nov 8, 2023
@wjiec
Copy link
Contributor Author

wjiec commented Nov 9, 2023

Indeed, please check this PR again when you have time. ☺️

@wjiec wjiec requested a review from derailed November 9, 2023 06:31
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Thank you for these updates Jayson!

@derailed derailed merged commit 893f15f into derailed:master Nov 10, 2023
2 of 3 checks passed
@wjiec wjiec deleted the bugfix/drain branch November 10, 2023 01:28
@derailed derailed mentioned this pull request Nov 11, 2023
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
* check if the Node already cordoned when executing Drain

* ensure node cordoned
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
* check if the Node already cordoned when executing Drain

* ensure node cordoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when draining node that is cordoned
2 participants