Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if the service provides selectors #2322

Merged
merged 1 commit into from Dec 1, 2023
Merged

check if the service provides selectors #2322

merged 1 commit into from Dec 1, 2023

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Nov 30, 2023

this PR fixes #1789.

derailed
derailed approved these changes Dec 1, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Nice! Thank for this update Jayson!!

@derailed derailed merged commit 4e37faf into derailed:master Dec 1, 2023
2 of 3 checks passed
@wjiec wjiec deleted the bugfix/svc-pods branch December 3, 2023 11:11
@derailed derailed mentioned this pull request Dec 7, 2023
Merged
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this pull request Feb 23, 2024
@wjiec @thejoeejoee
check if the service provides selectors (derailed#2322)
51f7e30
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
@wjiec
check if the service provides selectors (derailed#2322)
916cad0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support services without selectors
2 participants
@wjiec @derailed