Merge pull request #8220 from vilmibm/8156-openExternal

use openExternal async
desktop · Sep 10, 2019 · 284e374 · 284e374
2 parents 46a9980 + 1448b6d
commit 284e374
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/app/src/main-process/main.ts b/app/src/main-process/main.ts
@@ -486,7 +486,7 @@ app.on('ready', () => {
 
   ipcMain.on(
     'open-external',
-    (event: Electron.IpcMessageEvent, { path }: { path: string }) => {
+    async (event: Electron.IpcMessageEvent, { path }: { path: string }) => {
       const pathLowerCase = path.toLowerCase()
       if (
         pathLowerCase.startsWith('http://') ||
@@ -495,7 +495,14 @@ app.on('ready', () => {
         log.info(`opening in browser: ${path}`)
       }
 
-      const result = shell.openExternal(path)
+      let result
+      try {
+        await shell.openExternal(path)
+        result = true
+      } catch (e) {
+        log.error(`Call to openExternal failed: '${e}'`)
+        result = false
+      }
       event.sender.send('open-external-result', { result })
     }
   )