Increase title bar height on Big Sur #11017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Minimizes the surface area of this change
|
I was able to install Big Sur in a VM and that was a good thing because it turns out Apple will lie about the version number to Electron saying it's 10.16 rather than 11.0 since electron (or chromium) isn't compiled against the Big Sur SDK, see electron/electron#26419. We're able to work around that though and here's the results (the dimmed traffic lights are from the production app)
I'm happy with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10980
Description
Seems macOS Big Sur (which is launching today) has a taller title bar making our traffic lights seem misaligned. Only judging from the screenshot in #10980 it looks like the title bar height increased by 4px so I've adjusted our title bar accordingly. Note that I haven't had a chance to actually test this on Big Sur yet.
While I was looking at this I noticed some needlessly complex logic to determine the current platform version which could be simplified thanks to electron/electron#16599.
Release notes
Notes: [Fixed] Adjust title bar height on Big Sur to match new platform convention