Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies in order to support arm64 builds for macOS #12083

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

sergiou87
Copy link
Member

Description

This PR bumps keytar, fs-admin, registry-js and desktop-trampoline to builds with N-API support, so that we can finally build a macOS beta with some arm64 support 😄

Release notes

Notes: no-notes

@sergiou87 sergiou87 requested a review from tidy-dev April 27, 2021 12:17
@@ -1 +1 @@
v14
v14.15.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version we use in our CI scripts. Using something lower than 14.1 will fail when building the app due to max-mapper/extract-zip#94

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiou87 sergiou87 merged commit dafe97e into development Apr 27, 2021
@sergiou87 sergiou87 deleted the bump-arm64-deps branch April 27, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants