Add npm_config_arch for "Prepare testing environment" #17158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiou87
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently merged in a new macOS runner which is M1 or arm64.
This of course makes the mac's arch type to be
arm64instead ofx64and therefore thegetDistArchitecturemethod now returnedarm64by default on macOS builds. This was not noticeable in our regular ci builds because we set thenpm-config-archon our regular ci builds that rely on it being distinct from default. But, for our release processes, we have a few extra steps that are run where thenpm-config-archwas not specified and it didn't matter as thex64was expected. Thus, now, we need to specify it.Release notes
Notes: no-notes