Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Windows Automatic Dark Mode #9016

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Add Support for Windows Automatic Dark Mode #9016

merged 5 commits into from
Mar 9, 2020

Conversation

say25
Copy link
Member

@say25 say25 commented Jan 31, 2020 •
edited

⚠️Depends on #8967⚠️

Closes #9015

Description

  • Add automatic switching between Dark Mode and Light Mode on Windows.

Screenshots

WindowsDarkMode

Release notes

Notes: Add Support Automatic Dark Mode Switching on Windows

@say25 say25 added themes Issues related the light or dark themes that ship in Desktop and removed themes Issues related the light or dark themes that ship in Desktop labels Jan 31, 2020
@say25 say25 changed the base branch from releases/2.3.0-test2 to development February 7, 2020 15:31
@say25 say25 closed this Feb 7, 2020
@say25 say25 force-pushed the windows-automatic-dark-mode branch from 082de01 to 46d0f84 Compare February 7, 2020 18:17
@say25 say25 reopened this Feb 7, 2020
@say25 say25 added ready-for-review Pull Requests that are ready to be reviewed by the maintainers themes Issues related the light or dark themes that ship in Desktop windows Issues specific Desktop usage on Windows labels Feb 7, 2020
@billygriffin billygriffin added this to In Progress PRs in Desktop 2.4 release via automation Feb 12, 2020
@billygriffin billygriffin moved this from In Progress PRs to Awaiting Review in Desktop 2.4 release Feb 12, 2020
@kuychaco kuychaco self-requested a review March 3, 2020 18:19
@kuychaco kuychaco self-assigned this Mar 3, 2020
kuychaco
kuychaco reviewed Mar 4, 2020
View reviewed changes
Copy link
Contributor

@kuychaco kuychaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @say25! It looks great overall ✨. I left a few comments inline.

app/src/lib/get-os.ts Outdated Show resolved Hide resolved
app/src/lib/get-os.ts Outdated Show resolved Hide resolved
app/src/ui/lib/dark-theme.ts Outdated Show resolved Hide resolved
Rexogamer
Rexogamer reviewed Mar 5, 2020
View reviewed changes
app/src/lib/get-os.ts Outdated Show resolved Hide resolved
@say25 say25 force-pushed the windows-automatic-dark-mode branch from d8ce90c to bf9f762 Compare March 6, 2020 19:15
tierninho
tierninho previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@tierninho tierninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the OSX functionality is still intact with this change.

Rexogamer
Rexogamer reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@Rexogamer Rexogamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

app/src/lib/get-os.ts Outdated Show resolved Hide resolved
Desktop 2.4 release automation moved this from Awaiting Review to Review In Progress Mar 6, 2020
@say25
Copy link
Member Author

say25 commented Mar 6, 2020

@tierninho I apologize for dismissing your review, fixed a typo in a comment

say25
say25 commented Mar 6, 2020
View reviewed changes
app/src/lib/get-os.ts Outdated Show resolved Hide resolved
kuychaco
kuychaco approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@kuychaco kuychaco left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great @say25! Thanks for the contribution and the prompt feedback incorporation!

I want to do one last round of QA on Windows on Monday before merging.

Update: tested on windows and looks great!

@kuychaco kuychaco merged commit 95582bc into desktop:development Mar 9, 2020
Desktop 2.4 release automation moved this from Review In Progress to PRs For Next Beta Mar 9, 2020
@say25 say25 deleted the windows-automatic-dark-mode branch March 9, 2020 19:50
@outofambit outofambit moved this from PRs For Next Beta to Done! in Desktop 2.4 release Mar 17, 2020
@say25 say25 mentioned this pull request Feb 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rexogamer Rexogamer Rexogamer left review comments

@Chadapa15099 Chadapa15099 Chadapa15099 left review comments

@kuychaco kuychaco kuychaco approved these changes

@tierninho tierninho tierninho left review comments

Assignees

@kuychaco kuychaco

Labels
ready-for-review Pull Requests that are ready to be reviewed by the maintainers themes Issues related the light or dark themes that ship in Desktop windows Issues specific Desktop usage on Windows
Projects
No open projects
Desktop 2.4 release
Done!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Automatic Dark Mode Switching on Windows
5 participants
@say25 @kuychaco @tierninho @Rexogamer @Chadapa15099