mock remote.nativeTheme for tests #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outofambit
added
the
infrastructure
|
👍 I poked at what this resolves to on Linux and it seems to be a real object with those functions attached - making the tests reflect that is probably The Best Way To Fix This™ |
say25
approved these changes
May 5, 2020
dennisameling
approved these changes
May 5, 2020
There was a problem hiding this comment.
Nice fix!! Thanks @outofambit! 😄 🎉 Just tested on Windows 10 1909 and works as expected 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9699
supersedes #9700
Description
adds a jest mock for
remote.nativeThemei opted for this approach to ensure we don't affect non-test environment behavior (even though that is highly unlikely). we already mock other parts of the electron api for tests, so this also follows that approach.
(i tried this out in #9680 to make sure it worked. the tests are still failing there but for a different reason now, so WIN 😛)
cc @shiftkey @dennisameling