Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel git operation with CTRL+C signal #536

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Cancel git operation with CTRL+C signal #536

wants to merge 18 commits into from

Commits on Apr 1, 2023

  1. adding SIGINT to kill on cancel command

    @maifeeulasad
    maifeeulasad committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    44e590e View commit details
    Browse the repository at this point in the history

  2. [test]: check if the clone cancel is properly working or not

    @maifeeulasad
    maifeeulasad committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    ee2b41b View commit details
    Browse the repository at this point in the history

  3. on task cancel we need to want for task result,validated on linux

    @maifeeulasad
    maifeeulasad committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    9e29a2b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. added **ctrlc-node-pid** native package to dependencies; calling `c… 

    …trlc.stopProgram` to stop the process;
    @maifeeulasad
    maifeeulasad committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    df1f284 View commit details
    Browse the repository at this point in the history

  2. added .cc source to this repo, instead of adding as a dependency

    @maifeeulasad
    maifeeulasad committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    48eacad View commit details
    Browse the repository at this point in the history

  3. remove ctrlc-node-pid from deps

    @maifeeulasad
    maifeeulasad committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f4504b7 View commit details
    Browse the repository at this point in the history

  4. prettify + git clone url gh/desktop/desktop

    @maifeeulasad
    maifeeulasad committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5d0403a View commit details
    Browse the repository at this point in the history

  5. [pipeline]: add node-gyp globally + configure and build node-gyp, msv… 

    …c and tools may raise an issue
    @maifeeulasad
    maifeeulasad committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    61a6841 View commit details
    Browse the repository at this point in the history

  6. call sigintWindows only if os is windows and action is clone; keep … 

    …track of git operation type along with pid;
    @maifeeulasad
    maifeeulasad committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c14dfe6 View commit details
    Browse the repository at this point in the history

  7. shuflle test to confirm pre-mature exit by ctrl+c;

    @maifeeulasad
    maifeeulasad committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    bb7d2ce View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. restore pipeline to original one; node-gyp install, configure, build … 

    …from script, only runs on windows on post-install
    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    15d2df8 View commit details
    Browse the repository at this point in the history

  2. ctrl, conditional import and run, based on `process.platform === 'win… 

    …32'`
    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e1b909c View commit details
    Browse the repository at this point in the history

  3. conditional .cc native code

    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ad9675d View commit details
    Browse the repository at this point in the history

  4. yarn should trigger node-gyp?

    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    638ebaa View commit details
    Browse the repository at this point in the history

  5. //lint

    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    dd76d01 View commit details
    Browse the repository at this point in the history

  6. no conditional import

    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d7fd1ad View commit details
    Browse the repository at this point in the history

  7. copy .node file from build to lib folder on post-install; putti… 

    …ng `.cc` file in `lib` folder;
    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4ae61bc View commit details
    Browse the repository at this point in the history

  8. //

    @maifeeulasad
    maifeeulasad committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    06a22a1 View commit details
    Browse the repository at this point in the history