Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only prebuild the versions currently supported by Node and Electron #139

Merged
merged 1 commit into from May 23, 2019

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented May 22, 2019

Node 10 is the current LTS, Node 12 is the latest, and Electron 3, 4 and 5 are the current set of maintained versions by the team.

@shiftkey shiftkey force-pushed the deprecate-unsupported-versions branch from c48976d to 28f3f9a Compare May 22, 2019 21:27
@shiftkey shiftkey force-pushed the deprecate-unsupported-versions branch from 28f3f9a to 92c54d1 Compare May 22, 2019 22:56
@shiftkey shiftkey merged commit dbceb16 into master May 23, 2019
@shiftkey shiftkey deleted the deprecate-unsupported-versions branch May 23, 2019 11:41
@pimterry
Copy link
Contributor

Just fyi @shiftkey - Node 10 is the current active LTS, but Node 8 is still supported as the maintenance LTS version until January 2020 (i.e. still officially supported, but only major & security bugs backported). See https://nodejs.org/en/about/releases/.

Not a big deal, but it would've been nice to keep prebuilds for Node 8 until then, since there's quite a few people still using it in production.

@shiftkey
Copy link
Member Author

@pimterry we're talking about this over in #145

@pimterry
Copy link
Contributor

Ah great, way ahead of me 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants