Introduce add finding to baseline action #270
Conversation
src/main/kotlin/io/gitlab/arturbosch/detekt/idea/action/AddToBaselineAction.kt
Outdated
Show resolved
Hide resolved
arturbosch
force-pushed
the
baseline-action
branch
from
7e7aa38
to
381468f
Compare
| val settings = project.service<DetektPluginSettings>() | ||
| if (project.isBaselineDefined()) { | ||
| val provider = BaselineProvider.load() | ||
| val baselinePath = Path(settings.baselinePath) |
There was a problem hiding this comment.
Each Gradle module can have its own Detekt baseline, right? I mean right now, all IDEA knows is what's set manually in Settings. Is it possible to work towards supporting this fully, or it would need changes to the Gradle integration of IDEA?
There was a problem hiding this comment.
Technically yes, this would be the state we want to achieve in the end.
A bit in the direction of #276.
The IntelliJ plugin should detect all config and baseline files automatically per module basis.
We do not communicate with the Gradle subsystem in IJ for now.
Idk if it would be possible to get the DetektExtension information from Gradle through IJ.
There was a problem hiding this comment.
I think the way you communicate with the Gradle build is to hook into the sync process, inject your own code, expose it via an extension point and access it from the Detekt IJ plugin. @lamba92 please correct me if I'm wrong
arturbosch
force-pushed
the
baseline-action
branch
from
381468f
to
2c27359
Compare
Needs support in tooling-api detekt/detekt#5239