UnusedPrivateMember: fix false positive with backtick parameters (#5252)

detekt · Aug 29, 2022 · 1a60429 · 1a60429
1 parent 2866976
commit 1a60429
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt b/...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt
@@ -258,7 +258,7 @@ private class UnusedParameterVisitor(allowedNames: Regex) : UnusedMemberVisitor(
             }
 
             override fun visitReferenceExpression(expression: KtReferenceExpression) {
-                parameters.remove(expression.text)
+                parameters.remove(expression.text.removeSurrounding("`"))
                 super.visitReferenceExpression(expression)
             }
         })

diff --git a/...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt b/...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt
@@ -1468,6 +1468,17 @@ class UnusedPrivateMemberSpec(val env: KotlinCoreEnvironment) {
         }
     }
 
+    @Nested
+    inner class `backtick identifiers - #5251` {
+        @Test
+        fun `does not report used backtick parameters`() {
+            val code = """
+                fun test(`foo bar`: Int) = `foo bar`
+            """
+            assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
+        }
+    }
+
     @Nested
     inner class `list get overloaded operator function - #3640` {
         @Test