Only write the file if it is different than the current one

detekt · Jan 4, 2022 · 321e265 · 321e265
1 parent aaa9ef0
commit 321e265
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/baseline/BaselineFacade.kt b/detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/baseline/BaselineFacade.kt
@@ -19,13 +19,13 @@ class BaselineFacade {
 
     fun createOrUpdate(baselineFile: Path, findings: List<Finding>) {
         val ids = findings.map { it.baselineId }.toSortedSet()
-        val exists = baselineExists(baselineFile)
-        val baseline = if (exists) {
-            Baseline.load(baselineFile).copy(currentIssues = ids)
+        val oldBaseline = if (baselineExists(baselineFile)) {
+            Baseline.load(baselineFile)
         } else {
-            Baseline(emptySet(), ids)
+            Baseline(emptySet(), emptySet())
         }
-        if (baseline.isNotEmpty() || exists) {
+        val baseline = oldBaseline.copy(currentIssues = ids)
+        if (oldBaseline != baseline) {
             baselineFile.parent?.let { Files.createDirectories(it) }
             BaselineFormat().write(baseline, baselineFile)
         }