Report CastToNullableType at the cast operator instead of the whole e…

…xpression (#5350) Closes #5346
detekt · Sep 25, 2022 · 7b73606 · 7b73606
1 parent 2db2098
commit 7b73606
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...s-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/CastToNullableType.kt b/...s-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/CastToNullableType.kt
@@ -47,6 +47,6 @@ class CastToNullableType(config: Config = Config.empty) : Rule(config) {
 
         val message = "Use the safe cast ('as? ${nullableTypeElement.innerType?.text}')" +
             " instead of 'as ${nullableTypeElement.text}'."
-        report(CodeSmell(issue, Entity.from(expression), message))
+        report(CodeSmell(issue, Entity.from(operationReference), message))
     }
 }
diff --git a/...rorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/CastToNullableTypeSpec.kt b/...rorprone/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/CastToNullableTypeSpec.kt
@@ -16,7 +16,7 @@ class CastToNullableTypeSpec {
         """.trimIndent()
         val findings = subject.compileAndLint(code)
         assertThat(findings).hasSize(1)
-        assertThat(findings).hasStartSourceLocation(2, 22)
+        assertThat(findings).hasStartSourceLocation(2, 24)
         assertThat(findings[0]).hasMessage("Use the safe cast ('as? String') instead of 'as String?'.")
     }