UnusedPrivateMember should not report external classes/interfaces (#4347

) * UnusedPrivateMember should not report external classes/interfaces * Clarify the tests
detekt · Dec 1, 2021 · 9bfba9a · 9bfba9a
1 parent 5e34645
commit 9bfba9a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt b/...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt
@@ -217,6 +217,7 @@ private class UnusedParameterVisitor(allowedNames: Regex) : UnusedMemberVisitor(
 
     override fun visitClass(klass: KtClass) {
         if (klass.isInterface()) return
+        if (klass.isExternal()) return
 
         super.visitClass(klass)
     }

diff --git a/...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt b/...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt
@@ -127,6 +127,21 @@ class UnusedPrivateMemberSpec : Spek({
         }
     }
 
+    describe("external classes") {
+
+        it("should not report functions in external classes") {
+            val code = """
+                external class Bugsnag {
+                    companion object {
+                        fun start(value: Int)
+                        fun notify(error: String)
+                    }
+                }
+                """
+            assertThat(subject.lint(code)).isEmpty()
+        }
+    }
+
     describe("protected functions") {
 
         it("should not report parameters in protected functions") {