Completely-empty abstract classes will now be flagged by UnnecessaryA…

…bstractClass (#4370) * Completely-empty abstract classes will now be flagged by UnnecessaryAbstractClass * Added test case to improve code coverage
detekt · Dec 15, 2021 · a9ce1e2 · a9ce1e2
1 parent b013465
commit a9ce1e2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/...style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryAbstractClass.kt b/...style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryAbstractClass.kt
@@ -78,7 +78,7 @@ class UnnecessaryAbstractClass(config: Config = Config.empty) : Rule(config) {
                 val namedMembers = body.children.filterIsInstance<KtNamedDeclaration>()
                 val namedClassMembers = NamedClassMembers(klass, namedMembers)
                 namedClassMembers.detectAbstractAndConcreteType()
-            } else if (klass.superTypeListEntries.isEmpty() && klass.hasConstructorParameter()) {
+            } else if (klass.superTypeListEntries.isEmpty()) {
                 report(CodeSmell(issue, Entity.from(klass), noAbstractMember), klass)
             }
         }

diff --git a/...e/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryAbstractClassSpec.kt b/...e/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryAbstractClassSpec.kt
@@ -44,6 +44,24 @@ class UnnecessaryAbstractClassSpec : Spek({
                 )
             }
 
+            it("reports completely-empty abstract classes") {
+                val code = """
+                    abstract class A
+                    abstract class B()
+                """
+                assertThat(subject.compileAndLintWithContext(env, code)).hasSize(2)
+            }
+
+            it("does not report a completely-empty abstract class that inherits from an interface") {
+                val code = """
+                    interface A {
+                        val i: Int
+                    }
+                    abstract class B : A
+                """.trimIndent()
+                assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
+            }
+
             it("does not report an abstract class with concrete members derived from a base class") {
                 val code = """
                     abstract class A {
@@ -191,14 +209,6 @@ class UnnecessaryAbstractClassSpec : Spek({
                 assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
             }
 
-            it("does not report empty abstract classes") {
-                val code = """
-                    abstract class A
-                    abstract class B()
-                """
-                assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
-            }
-
             it("does not report abstract classes with module annotation") {
                 val code = """
                     @Deprecated("test")