UnusedPrivateMember: fix false negative with named arguments (#5374)

detekt · Oct 5, 2022 · b4710a2 · b4710a2
1 parent b324516
commit b4710a2
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt b/...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt
@@ -39,6 +39,7 @@ import org.jetbrains.kotlin.psi.KtProperty
 import org.jetbrains.kotlin.psi.KtPropertyDelegate
 import org.jetbrains.kotlin.psi.KtReferenceExpression
 import org.jetbrains.kotlin.psi.KtSecondaryConstructor
+import org.jetbrains.kotlin.psi.KtValueArgumentName
 import org.jetbrains.kotlin.psi.psiUtil.containingClassOrObject
 import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
 import org.jetbrains.kotlin.psi.psiUtil.isPrivate
@@ -258,7 +259,9 @@ private class UnusedParameterVisitor(allowedNames: Regex) : UnusedMemberVisitor(
             }
 
             override fun visitReferenceExpression(expression: KtReferenceExpression) {
-                parameters.remove(expression.text.removeSurrounding("`"))
+                if (expression.parent !is KtValueArgumentName) {
+                    parameters.remove(expression.text.removeSurrounding("`"))
+                }
                 super.visitReferenceExpression(expression)
             }
         })

diff --git a/...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt b/...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt
@@ -1648,4 +1648,35 @@ class UnusedPrivateMemberSpec(val env: KotlinCoreEnvironment) {
             assertThat(subject.lint(code)).hasSize(1).hasStartSourceLocation(6, 9)
         }
     }
+
+    @Nested
+    inner class `parameter with the same name as a named argument #5373` {
+        @Test
+        fun `unused parameter`() {
+            val code = """
+                fun foo(modifier: Int) {
+                    bar(modifier = 1)
+                }
+                
+                fun bar(modifier: Int) {
+                    println(modifier)
+                }
+            """.trimIndent()
+            assertThat(subject.compileAndLintWithContext(env, code)).hasSize(1).hasStartSourceLocation(1, 9)
+        }
+
+        @Test
+        fun `used parameter`() {
+            val code = """
+                fun foo(modifier: Int) {
+                    bar(modifier = modifier)
+                }
+                
+                fun bar(modifier: Int) {
+                    println(modifier)
+                }
+            """.trimIndent()
+            assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
+        }
+    }
 }