ObjectPropertyNaming: fix false positive with top level properties (#…

…5390) Closes #5340
detekt · Oct 8, 2022 · cdb5928 · cdb5928
1 parent b6ad99d
commit cdb5928
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/...s-naming/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/naming/ObjectPropertyNaming.kt b/...s-naming/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/naming/ObjectPropertyNaming.kt
@@ -38,7 +38,7 @@ class ObjectPropertyNaming(config: Config = Config.empty) : Rule(config) {
     private val privatePropertyPattern: Regex by config("(_)?[A-Za-z][_A-Za-z0-9]*") { it.toRegex() }
 
     override fun visitProperty(property: KtProperty) {
-        if (property.isLocal) {
+        if (property.isLocal || property.isTopLevel) {
             return
         }
 

diff --git a/...ming/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/naming/ObjectPropertyNamingSpec.kt b/...ming/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/naming/ObjectPropertyNamingSpec.kt
@@ -237,6 +237,20 @@ class ObjectPropertyNamingSpec {
             assertThat(subject.compileAndLint(code)).isEmpty()
         }
     }
+
+    @Nested
+    inner class `top level properties` {
+        @Test
+        fun `should not detect top level properties`() {
+            val subject = ObjectPropertyNaming()
+
+            val code = """
+                val _invalidNaming = 1
+            """.trimIndent()
+
+            assertThat(subject.compileAndLint(code)).isEmpty()
+        }
+    }
 }
 
 @Suppress("UnnecessaryAbstractClass")