Skip to content

Commit

Permalink
Make detekt less noisy
Browse files Browse the repository at this point in the history
  • Loading branch information
BraisGabin committed Dec 29, 2021
1 parent d5b28e2 commit eb0bcfe
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 55 deletions.
Expand Up @@ -3,29 +3,35 @@ package io.gitlab.arturbosch.detekt.core
import org.jetbrains.kotlin.cli.common.messages.AnalyzerWithCompilerReport
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSourceLocation
import org.jetbrains.kotlin.cli.common.messages.MessageCollector
import org.jetbrains.kotlin.cli.common.messages.PlainTextMessageRenderer
import org.jetbrains.kotlin.cli.common.messages.PrintingMessageCollector
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
import org.jetbrains.kotlin.cli.jvm.compiler.NoScopeRecordCliBindingTrace
import org.jetbrains.kotlin.cli.jvm.compiler.TopDownAnalyzerFacadeForJVM
import org.jetbrains.kotlin.config.languageVersionSettings
import org.jetbrains.kotlin.psi.KtFile
import org.jetbrains.kotlin.resolve.BindingContext
import org.jetbrains.kotlin.resolve.lazy.declarations.FileBasedDeclarationProviderFactory
import java.io.PrintStream

internal fun generateBindingContext(
environment: KotlinCoreEnvironment,
classpath: List<String>,
files: List<KtFile>,
debugPrinter: (() -> String) -> Unit,
warningPrinter: (String) -> Unit,
): BindingContext {
if (classpath.isEmpty()) {
return BindingContext.EMPTY
}

val messageCollector = DetektMessageCollector(
debugPrinter = debugPrinter,
minSeverity = CompilerMessageSeverity.ERROR,
)

val analyzer = AnalyzerWithCompilerReport(
DetektMessageCollector(minSeverity = CompilerMessageSeverity.ERROR),
environment.configuration.languageVersionSettings
messageCollector,
environment.configuration.languageVersionSettings,
)
analyzer.analyzeAndReport(files) {
TopDownAnalyzerFacadeForJVM.analyzeFilesWithJavaIntegration(
Expand All @@ -37,17 +43,28 @@ internal fun generateBindingContext(
::FileBasedDeclarationProviderFactory
)
}

if (messageCollector.messages > 0) {
warningPrinter(
"The BindingContext was created with ${messageCollector.messages} issues. " +
"Run detekt with --debug to see the error messages."
)
}

return analyzer.analysisResult.bindingContext
}

internal class DetektMessageCollector(
errorStream: PrintStream = System.err,
verbose: Boolean = false,
private val minSeverity: CompilerMessageSeverity = CompilerMessageSeverity.ERROR
) : PrintingMessageCollector(errorStream, DetektMessageRenderer, verbose) {
private class DetektMessageCollector(
private val debugPrinter: (() -> String) -> Unit,
private val minSeverity: CompilerMessageSeverity,
) : MessageCollector by MessageCollector.NONE {
var messages = 0
private set

override fun report(severity: CompilerMessageSeverity, message: String, location: CompilerMessageSourceLocation?) {
if (severity.ordinal <= minSeverity.ordinal) {
super.report(severity, message, location)
debugPrinter { DetektMessageRenderer.render(severity, message, location) }
messages++
}
}
}
Expand Down
Expand Up @@ -60,7 +60,7 @@ internal class DefaultLifecycle(
override val settings: ProcessingSettings,
override val parsingStrategy: ParsingStrategy,
override val bindingProvider: (files: List<KtFile>) -> BindingContext =
{ generateBindingContext(settings.environment, settings.classpath, it) },
{ generateBindingContext(settings.environment, settings.classpath, it, settings::debug, settings::info) },
override val processorsProvider: () -> List<FileProcessListener> =
{ FileProcessorLocator(settings).load() },
override val ruleSetsProvider: () -> List<RuleSetProvider> =
Expand Down

This file was deleted.

0 comments on commit eb0bcfe

Please sign in to comment.