Convert previously known string property to list based on default val…

…ue - #5323

detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/SplitPattern.kt

@@ -57,7 +57,7 @@ open class SplitPattern(
 }
 
 /**
- * Splits given String into a sequence of strings splited by the provided delimiters ("," by default).
+ * Splits given String into a sequence of strings split by the provided delimiters ("," by default).
  *
  * It also trims the strings and removes the empty ones
  */

detekt-cli/src/test/kotlin/io/gitlab/arturbosch/detekt/cli/runners/RunnerSpec.kt

@@ -13,6 +13,7 @@ import org.assertj.core.api.Assertions.assertThatThrownBy
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Nested
 import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.assertDoesNotThrow
 import java.nio.file.Files
 import java.nio.file.Path
 
@@ -299,4 +300,19 @@ class RunnerSpec {
             executeDetekt("--input", inputPath.toString(), "--max-issues", "2")
         }
     }
+
+    @Test
+    fun `regression - rule property, changed from comma separated string to list, throws on wrapped configs`() {
+        assertDoesNotThrow {
+            executeDetekt(
+                "--all-rules", // wrapped config
+                "--input",
+                inputPath.toString(),
+                "--config-resource",
+                "configs/return-count-with-string-property.yml",
+                "--max-issues",
+                "-1"
+            )
+        }
+    }
 }

detekt-cli/src/test/resources/configs/return-count-with-string-property.yml

@@ -0,0 +1,4 @@
+style:
+  ReturnCount:
+    active: true
+    excludedFunctions: 'test'

detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/config/BaseConfig.kt

@@ -2,6 +2,7 @@ package io.gitlab.arturbosch.detekt.core.config
 
 import io.gitlab.arturbosch.detekt.api.Config
 import io.gitlab.arturbosch.detekt.api.Config.Companion.CONFIG_SEPARATOR
+import io.gitlab.arturbosch.detekt.api.commaSeparatedPattern
 
 private val ALLOWED_BOOL_VALUES = setOf("true", "false")
 
@@ -48,5 +49,6 @@ fun tryParseBasedOnDefault(result: String, defaultResult: Any): Any = when (defa
         }
     is Double -> result.toDouble()
     is String -> result
+    is List<*> -> result.commaSeparatedPattern().toList()
     else -> throw ClassCastException()
 }