RethrowCaughtException should not be triggered when there is more general exception below

[matejdro]

Expected Behavior of the rule

Following code should be compliant with RethrowCaughtException rule:

try {
    // Do something
} catch (e: CancellationException) {
    // Just throw cancellation
    throw e
} catch (e: Exception) {
    // Log everything except cancellation
    logException(e)
}

Context

In above case I want to log all exceptions except for the Cancellation exception (which I just want to propagate). That's why CancellationException has its own catch that gets activated before the general one, which is then never reached. This cause clause is not useless because it is used to filter more general cause clauses that come after it.

Above snippet is just a more cleaner way to write following code, which is compliant:

try {
    // Do something
} catch (e: Exception) {
    if (e is CancellationException) {
        throw e
    } else {
        logException(e)
    }
}

[BraisGabin]

You are right. Do you want to give it a try and send a PR solving it?

[strkkk]

@BraisGabin I would like to give it a try

[BraisGabin]

Go for it! Let me know if you need any help :)