New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positive in RethrowCaughtException for try with more than one catch (#4367) #4369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 really good first contribution :) Thanks!
...s/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/exceptions/RethrowCaughtExceptionSpec.kt
Show resolved
Hide resolved
c619c94
to
69e7ca2
Compare
Codecov Report
@@ Coverage Diff @@
## main #4369 +/- ##
=========================================
Coverage 84.33% 84.33%
- Complexity 3269 3272 +3
=========================================
Files 473 473
Lines 10343 10351 +8
Branches 1825 1826 +1
=========================================
+ Hits 8723 8730 +7
Misses 668 668
- Partials 952 953 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding request for changes becuase right now it introduces a false-negative as commented in this thread: https://github.com/detekt/detekt/pull/4369/files#r767144893
69e7ca2
to
2c75b65
Compare
Thank you so much! I'll merge it as soon as CI passes :). Greate job. |
There is an issue in the code, could you check and fix it? https://github.com/detekt/detekt/runs/4594574549?check_suite_focus=true#step:4:356 |
2c75b65
to
db779d1
Compare
db779d1
to
a057707
Compare
@BraisGabin please trigger ci |
Closes #4367
this
qualifier)