Upgrade AGP to 7

[chao2zhang]

Used https://github.com/cortinico/kotlin-android-template for local testing. It appears to work fine.

EDIT: Now that AGP 7 drops support for Java 8, at some point I think we also need to move towards Java 11.

[codecov]

Codecov Report

Merging #4133 (0543130) into main (d111fe4) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4133      +/-   ##
============================================
- Coverage     84.28%   84.08%   -0.21%     
- Complexity     3282     3305      +23     
============================================
  Files           474      473       -1     
  Lines         10429    10787     +358     
  Branches       1861     1992     +131     
============================================
+ Hits           8790     9070     +280     
- Misses          670      688      +18     
- Partials        969     1029      +60     

Impacted Files	Coverage Δ
...lab/arturbosch/detekt/rules/style/VarCouldBeVal.kt	84.37% <0.00%> (-5.21%)	⬇️
...b/arturbosch/detekt/core/tooling/AnalysisFacade.kt	62.85% <0.00%> (-3.81%)	⬇️
...h/detekt/rules/style/MultilineLambdaItParameter.kt	88.88% <0.00%> (-3.71%)	⬇️
...osch/detekt/core/baseline/BaselineResultMapping.kt	78.57% <0.00%> (-2.68%)	⬇️
.../arturbosch/detekt/rules/style/CanBeNonNullable.kt	71.60% <0.00%> (-1.54%)	⬇️
...osch/detekt/rules/bugs/UselessPostfixExpression.kt	71.73% <0.00%> (-0.99%)	⬇️
...urbosch/detekt/rules/performance/ArrayPrimitive.kt	74.19% <0.00%> (-0.81%)	⬇️
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt	86.66% <0.00%> (-0.29%)	⬇️
...etekt/generator/printer/defaultconfig/Exclusion.kt	96.66% <0.00%> (-0.11%)	⬇️
...gitlab/arturbosch/detekt/core/tooling/Lifecycle.kt	100.00% <0.00%> (ø)
... and 37 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d111fe4...0543130. Read the comment docs.

[chao2zhang]

This PR is pending on the outcome of #4130

[3flex]

To unblock this can we not just restrict the tests to running on JDK 11? We already limit which JDKs can be used to run the Android tests by blocking JDK 16+ due to GSON incompatibility (used by AGP - I haven't tested if that imcompatibility is fixed in AGP 7):

internal fun skipIfAndroidEnvironmentRequirementsUnmet() = when {
    !isAndroidSdkInstalled() -> Skip.Yes("No android SDK.")
    getJdkVersion() >= 16 -> Skip.Yes("Android 4.1.3 & 4.2.1 don't run on JDK 16 or higher")
    else -> Skip.No
}

[chao2zhang]

I agree with you, contingent on the assumption that users are building at least JDK 11 for Android Projects. Maybe we should announce that we can guarantee compatibility with the latest AGP release?

[cortinico]

Maybe we should announce that we can guarantee compatibility with the latest AGP release?

It's essentially already described on this page:
https://detekt.github.io/detekt/compatibility.html

Once we bump AGP to 7.x, we're implicitly dropping support for AGP 4.x
That means that is safe to assume that, if you're using Detekt 1.20.x (or whichever version this PR will land into), you're on AGP 7.x and JDK 11.
If you're not, you're on your own essentially ¯_(ツ)_/¯

[BraisGabin]

6 months since agp 7.0 was launched. I'm ok dropping support for agp 4.

[chao2zhang]

👍