Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify YamlConfig #4316

Merged
merged 2 commits into from Nov 24, 2021
Merged

Simplify YamlConfig #4316

merged 2 commits into from Nov 24, 2021

Conversation

BraisGabin
Copy link
Member

YamlConfig.loadResource(URL) is not needed as method. We can use YamlConfig.load(Reader) and convert the URLs to readers when calling.

This is part of the refactor to implement #4315

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #4316 (0fabcf1) into main (7b8d273) will decrease coverage by 0.01%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4316      +/-   ##
============================================
- Coverage     84.22%   84.20%   -0.02%     
  Complexity     3258     3258              
============================================
  Files           472      473       +1     
  Lines         10309    10309              
  Branches       1820     1821       +1     
============================================
- Hits           8683     8681       -2     
  Misses          666      666              
- Partials        960      962       +2     
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/core/config/YamlConfig.kt 85.71% <ø> (+0.86%) ⬆️
...lin/io/github/detekt/tooling/internal/Resources.kt 50.00% <50.00%> (ø)
...lab/arturbosch/detekt/core/config/DefaultConfig.kt 66.66% <66.66%> (-33.34%) ⬇️
...ab/arturbosch/detekt/core/config/Configurations.kt 84.37% <100.00%> (ø)
...bosch/detekt/core/tooling/DefaultConfigProvider.kt 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8d273...0fabcf1. Read the comment docs.

@cortinico cortinico added this to the 1.19.0 milestone Nov 23, 2021
@BraisGabin BraisGabin merged commit 03f9b97 into main Nov 24, 2021
@BraisGabin BraisGabin deleted the simplify-yamlconfig branch November 24, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants