Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnusedPrivateMember should not report external classes/interfaces #4347

Merged
merged 2 commits into from Dec 1, 2021
Merged

UnusedPrivateMember should not report external classes/interfaces #4347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c30366
UnusedPrivateMember should not report external classes/interfaces
cortinico Nov 30, 2021
e34f95c
Clarify the tests
cortinico Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt
View file
Open in desktop
Expand Up @@ -217,6 +217,7 @@ private class UnusedParameterVisitor(allowedNames: Regex) : UnusedMemberVisitor(

override fun visitClass(klass: KtClass) {
if (klass.isInterface()) return
if (klass.isExternal()) return

super.visitClass(klass)
}
Expand Down
15 changes: 15 additions & 0 deletions ...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt
View file
Open in desktop
Expand Up @@ -127,6 +127,21 @@ class UnusedPrivateMemberSpec : Spek({
}
}

describe("external classes") {

it("should not report functions in external classes") {
val code = """
external class Bugsnag {
companion object {
fun start(value: Int)
fun notify(error: String)
}
}
"""
assertThat(subject.lint(code)).isEmpty()
}
}

describe("protected functions") {

it("should not report parameters in protected functions") {
Expand Down