Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing and rule improvement for EmptyElseBlock #4349

Merged
merged 4 commits into from Dec 2, 2021
Merged

Testing and rule improvement for EmptyElseBlock #4349

merged 4 commits into from Dec 2, 2021

Conversation

severn-everett
Copy link
Contributor

Resolving issue #4206 by creating tests for EmptyElseBlock and standardizing the logic for both empty if- and else-block rules.

@cortinico cortinico added this to the 1.20.0 milestone Dec 2, 2021
@cortinico cortinico added the rules label Dec 2, 2021
chao2zhang
chao2zhang approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@chao2zhang chao2zhang linked an issue Dec 2, 2021 that may be closed by this pull request
Missing test for EmptyElseBlock rule #4206
Closed
@chao2zhang chao2zhang merged commit ed829aa into detekt:main Dec 2, 2021
@severn-everett severn-everett deleted the empty_else_false_negative branch December 10, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chao2zhang chao2zhang chao2zhang approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Missing test for EmptyElseBlock rule
3 participants
@severn-everett @chao2zhang @cortinico