Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NullCheckOnMutableProperty] Created rule for when a null-check is performed on a mutable property #4353

Merged
merged 17 commits into from Dec 31, 2021
Merged

[NullCheckOnMutableProperty] Created rule for when a null-check is performed on a mutable property #4353

merged 17 commits into from Dec 31, 2021

Commits on Dec 2, 2021

  1. Created rule for when a null-check is performed on a mutable property

    @severn-everett
    severn-everett committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    556166d View commit details
    Browse the repository at this point in the history

  2. Fixed Detekt issue

    @severn-everett
    severn-everett committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    c83d3da View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Added tests to improve code coverage

    @severn-everett
    severn-everett committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    1beced5 View commit details
    Browse the repository at this point in the history

  2. Fixed Detekt issues

    @severn-everett
    severn-everett committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    d3995e5 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Rule will now only fire when the candidate variable is actually refer… 

    …enced within the if-expression block; Moved all relevant inspection code to within a private class to ensure resource cleanup after visiting a Kotlin file
    @severn-everett
    severn-everett committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    db26bac View commit details
    Browse the repository at this point in the history

  2. Consolidated null-checking on candidateFqName

    @severn-everett
    severn-everett committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    c6e6137 View commit details
    Browse the repository at this point in the history

  3. More consolidation within visitIfExpression; Fixed Detekt issue in Nu… 

    …llCheckOnMutablePropertySpec
    @severn-everett
    severn-everett committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    1e7b0cf View commit details
    Browse the repository at this point in the history

  4. Switch to interface type specification in declaration of candidatePro… 

    …perties
    @severn-everett
    severn-everett committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    60c747d View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Merge branch 'master' into create_null_check_on_mutable_property

    @severn-everett
    severn-everett committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    7373b14 View commit details
    Browse the repository at this point in the history

  2. Added checks for multi-clause if-expressions

    @severn-everett
    severn-everett committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    dee8d9c View commit details
    Browse the repository at this point in the history

  3. Fixed Detekt issue

    @severn-everett
    severn-everett committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    0b1ba46 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Added check for val properties that have getters that return potentia… 

    …lly-nullable values
    @severn-everett
    severn-everett committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    614657b View commit details
    Browse the repository at this point in the history

  2. Address Detekt issue

    @severn-everett
    severn-everett committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    4713eb9 View commit details
    Browse the repository at this point in the history

  3. Fix failures in test compilation

    @severn-everett
    severn-everett committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    2b80d7a View commit details
    Browse the repository at this point in the history

  4. Simplified check on getter - will now only report if a val property p… 

    …ossesses a getter
    @severn-everett
    severn-everett committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    625afc1 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Addressing PR comments

    @severn-everett
    severn-everett committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    609faa5 View commit details
    Browse the repository at this point in the history

  2. Fixed typo

    @severn-everett
    severn-everett committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    85edb20 View commit details
    Browse the repository at this point in the history