New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AnnotationExcluder
tests
#4368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4368 +/- ##
============================================
- Coverage 84.26% 84.16% -0.11%
- Complexity 3263 3330 +67
============================================
Files 473 474 +1
Lines 10336 10862 +526
Branches 1827 2007 +180
============================================
+ Hits 8710 9142 +432
- Misses 667 689 +22
- Partials 959 1031 +72
Continue to review full report at Codecov.
|
788c064
to
84a8b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the tests to clarify type I and II errors
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/AnnotationExcluder.kt
Outdated
Show resolved
Hide resolved
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/AnnotationExcluderSpec.kt
Show resolved
Hide resolved
…otationExcluder.kt Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>
Because of #4355 and #4356 we will need to keep
AnnotationExcluder
class. But that class has a lot of errors as you can check in the tests of this PR. This PR just improves the test and make some minor improvements in the class. The next PR will refactorice it heavily to make all those errors spotted in the test to work.