Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AnnotationExcluder tests #4368

Merged
merged 5 commits into from Jan 23, 2022
Merged

Improve AnnotationExcluder tests #4368

merged 5 commits into from Jan 23, 2022

Conversation

BraisGabin
Copy link
Member

Because of #4355 and #4356 we will need to keep AnnotationExcluder class. But that class has a lot of errors as you can check in the tests of this PR. This PR just improves the test and make some minor improvements in the class. The next PR will refactorice it heavily to make all those errors spotted in the test to work.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #4368 (80ac80a) into main (92433ea) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4368      +/-   ##
============================================
- Coverage     84.26%   84.16%   -0.11%     
- Complexity     3263     3330      +67     
============================================
  Files           473      474       +1     
  Lines         10336    10862     +526     
  Branches       1827     2007     +180     
============================================
+ Hits           8710     9142     +432     
- Misses          667      689      +22     
- Partials        959     1031      +72     
Impacted Files Coverage Δ
...etekt/rules/style/FunctionOnlyReturningConstant.kt 95.34% <ø> (-0.11%) ⬇️
...gitlab/arturbosch/detekt/api/AnnotationExcluder.kt 81.25% <100.00%> (+14.58%) ⬆️
...bosch/detekt/rules/complexity/LongParameterList.kt 85.41% <100.00%> (-0.30%) ⬇️
...tlab/arturbosch/detekt/rules/bugs/LateinitUsage.kt 91.30% <100.00%> (-0.37%) ⬇️
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 86.36% <100.00%> (+1.58%) ⬆️
...tlab/arturbosch/detekt/rules/style/UseDataClass.kt 80.00% <100.00%> (+1.12%) ⬆️
...lab/arturbosch/detekt/rules/style/VarCouldBeVal.kt 84.37% <0.00%> (-5.21%) ⬇️
...b/arturbosch/detekt/core/tooling/AnalysisFacade.kt 62.85% <0.00%> (-3.81%) ⬇️
...h/detekt/rules/style/MultilineLambdaItParameter.kt 88.88% <0.00%> (-3.71%) ⬇️
...osch/detekt/core/baseline/BaselineResultMapping.kt 78.57% <0.00%> (-2.68%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92433ea...80ac80a. Read the comment docs.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Dec 26, 2021
@BraisGabin BraisGabin added this to the 1.20.0 milestone Dec 26, 2021
@chao2zhang chao2zhang self-requested a review January 22, 2022 20:16
Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the tests to clarify type I and II errors

…otationExcluder.kt

Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>
@chao2zhang chao2zhang merged commit a6c8435 into main Jan 23, 2022
@chao2zhang chao2zhang deleted the AnnotationExcluder branch January 23, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants