Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely-empty abstract classes will now be flagged by UnnecessaryAbstractClass #4370

Merged
merged 2 commits into from Dec 15, 2021
Merged

Completely-empty abstract classes will now be flagged by UnnecessaryAbstractClass #4370

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b8a374
Completely-empty abstract classes will now be flagged by UnnecessaryA…
severn-everett Dec 11, 2021
b9d6716
Added test case to improve code coverage
severn-everett Dec 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryAbstractClass.kt
View file
Open in desktop
Expand Up @@ -78,7 +78,7 @@ class UnnecessaryAbstractClass(config: Config = Config.empty) : Rule(config) {
val namedMembers = body.children.filterIsInstance<KtNamedDeclaration>()
val namedClassMembers = NamedClassMembers(klass, namedMembers)
namedClassMembers.detectAbstractAndConcreteType()
} else if (klass.superTypeListEntries.isEmpty() && klass.hasConstructorParameter()) {
} else if (klass.superTypeListEntries.isEmpty()) {
report(CodeSmell(issue, Entity.from(klass), noAbstractMember), klass)
}
}
Expand Down
16 changes: 8 additions & 8 deletions ...e/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryAbstractClassSpec.kt
View file
Open in desktop
Expand Up @@ -44,6 +44,14 @@ class UnnecessaryAbstractClassSpec : Spek({
)
}

it("reports completely-empty abstract classes") {
val code = """
abstract class A
abstract class B()
"""
assertThat(subject.compileAndLintWithContext(env, code)).hasSize(2)
}

it("does not report an abstract class with concrete members derived from a base class") {
val code = """
abstract class A {
Expand Down Expand Up @@ -191,14 +199,6 @@ class UnnecessaryAbstractClassSpec : Spek({
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}

it("does not report empty abstract classes") {
val code = """
abstract class A
abstract class B()
"""
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}

it("does not report abstract classes with module annotation") {
val code = """
@Deprecated("test")
Expand Down