Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid usage of java.lang.ClassLoader.getResourceAsStream #4381

Merged
merged 2 commits into from Dec 18, 2021
Merged

Conversation

BraisGabin
Copy link
Member

Fixes #4364

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #4381 (4af5025) into main (f85c0da) will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4381      +/-   ##
============================================
+ Coverage     84.29%   84.33%   +0.04%     
+ Complexity     3271     3269       -2     
============================================
  Files           473      473              
  Lines         10341    10343       +2     
  Branches       1829     1825       -4     
============================================
+ Hits           8717     8723       +6     
  Misses          668      668              
+ Partials        956      952       -4     
Impacted Files Coverage Δ
...ab/arturbosch/detekt/core/config/ValidateConfig.kt 98.64% <85.71%> (-1.36%) ⬇️
...n/kotlin/io/gitlab/arturbosch/detekt/api/Entity.kt 75.00% <0.00%> (-1.20%) ⬇️
.../detekt/rules/exceptions/ObjectExtendsThrowable.kt 80.95% <0.00%> (ø)
...t/generator/collection/RuleSetProviderCollector.kt 75.94% <0.00%> (+1.26%) ⬆️
...tlab/arturbosch/detekt/rules/style/UseDataClass.kt 80.28% <0.00%> (+1.40%) ⬆️
...osch/detekt/rules/exceptions/SwallowedException.kt 77.04% <0.00%> (+1.63%) ⬆️
...b/arturbosch/detekt/core/reporting/OutputFacade.kt 90.90% <0.00%> (+4.54%) ⬆️
...gitlab/arturbosch/detekt/api/AnnotationExcluder.kt 73.33% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85c0da...4af5025. Read the comment docs.

@BraisGabin BraisGabin merged commit aa2bc99 into main Dec 18, 2021
@BraisGabin BraisGabin deleted the fix-4364 branch December 18, 2021 16:28
@schalkms schalkms added this to the 1.20.0 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random Stream closed in multiproject build, Detekt 1.19.0, JDK 1.8
3 participants