Don't define classes on default package #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
improve-ObjectLiteralToLambdaSpec-tests
branch
from
5f6461e
to
3680ff4
Compare
Codecov Report
@@ Coverage Diff @@
## main #4401 +/- ##
============================================
+ Coverage 84.33% 84.35% +0.01%
- Complexity 3272 3277 +5
============================================
Files 473 473
Lines 10351 10357 +6
Branches 1826 1827 +1
============================================
+ Hits 8730 8737 +7
Misses 668 668
+ Partials 953 952 -1
Continue to review full report at Codecov.
|
schalkms
approved these changes
Dec 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests were kind of difficult to understand because the import was a bit "obscure". I think that with this refactor it's easier to understand what's going on.