Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MultiRuleCollector.kt consistent with the DoubleMutabilityForCollection rule #4405

Merged
merged 1 commit into from Dec 27, 2021

Conversation

schalkms
Copy link
Member

Closes #4042

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #4405 (eb69861) into main (48a28fc) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4405      +/-   ##
============================================
+ Coverage     84.23%   84.28%   +0.04%     
- Complexity     3259     3280      +21     
============================================
  Files           474      474              
  Lines         10323    10425     +102     
  Branches       1825     1859      +34     
============================================
+ Hits           8696     8787      +91     
- Misses          666      670       +4     
- Partials        961      968       +7     
Impacted Files Coverage Δ
.../detekt/generator/collection/MultiRuleCollector.kt 74.62% <100.00%> (ø)
.../gitlab/arturbosch/detekt/rules/empty/EmptyRule.kt 92.30% <0.00%> (-3.15%) ⬇️
...etekt/rules/style/optional/MandatoryBracesLoops.kt 73.33% <0.00%> (-2.53%) ⬇️
...ab/arturbosch/detekt/core/config/ValidateConfig.kt 98.64% <0.00%> (-1.36%) ⬇️
...n/kotlin/io/gitlab/arturbosch/detekt/api/Entity.kt 75.00% <0.00%> (-1.20%) ⬇️
.../gitlab/arturbosch/detekt/api/internal/Versions.kt 87.50% <0.00%> (ø)
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.55% <0.00%> (ø)
.../arturbosch/detekt/generator/out/AbstractWriter.kt 0.00% <0.00%> (ø)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <0.00%> (ø)
.../detekt/rules/exceptions/ObjectExtendsThrowable.kt 80.95% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a28fc...eb69861. Read the comment docs.

@schalkms schalkms added this to the 1.20.0 milestone Dec 27, 2021
@schalkms schalkms merged commit 1dd51bc into main Dec 27, 2021
@schalkms schalkms deleted the #4042 branch December 27, 2021 17:27
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository is not consistent with the DoubleMutabilityForCollection rule
3 participants