Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formulate rule/complexity descriptions consistently #4417

Merged
merged 2 commits into from Dec 28, 2021
Merged

Formulate rule/complexity descriptions consistently #4417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8668965
Formulate rule/complexity descriptions consistently
schalkms Dec 27, 2021
1c5fca4
Apply suggestions from code review for msg
schalkms Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...complexity/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NamedArguments.kt
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ class NamedArguments(config: Config = Config.empty) : Rule(config) {
override val issue = Issue(
"NamedArguments",
Severity.Maintainability,
"Parameters of function invocation must all be named",
"Named arguments are required for function invocation with many parameters.",
Debt.FIVE_MINS
)

Expand Down
2 changes: 1 addition & 1 deletion ...c/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/ReplaceSafeCallChainWithRun.kt
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ class ReplaceSafeCallChainWithRun(config: Config = Config.empty) : Rule(config)
override val issue = Issue(
javaClass.simpleName,
Severity.Maintainability,
"Chains of safe calls on non-nullable types can be surrounded with run {}",
"Chains of safe calls on non-nullable types can be surrounded with `run {}`.",
Debt.TEN_MINS
)

Expand Down
3 changes: 2 additions & 1 deletion .../src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/StringLiteralDuplication.kt
View file
Open in desktop
Expand Up @@ -48,7 +48,8 @@ class StringLiteralDuplication(config: Config = Config.empty) : Rule(config) {
override val issue = Issue(
javaClass.simpleName,
Severity.Maintainability,
"Multiple occurrences of the same string literal within a single file detected.",
"Multiple occurrences of the same string literal within a single file detected. " +
"Prefer extracting the string literal into a property or constant.",
Debt.FIVE_MINS
)

Expand Down