Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CanBeNonNullable rule to check function params #4431

Merged
merged 24 commits into from Jan 12, 2022
Merged

Extend CanBeNonNullable rule to check function params #4431

merged 24 commits into from Jan 12, 2022

Commits on Dec 30, 2021

  1. Expanded CanBeNonNullable rule to check for function parameters that … 

    …can be marked as non-nullable
    @severn-everett
    severn-everett committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    47e858e View commit details
    Browse the repository at this point in the history

  2. Added code comment

    @severn-everett
    severn-everett committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    7abf6ae View commit details
    Browse the repository at this point in the history

  3. Addressing Detekt issue

    @severn-everett
    severn-everett committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    9197f1b View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Reworked CanBeNonNullable check for params based on PR discussion

    @severn-everett
    severn-everett committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    7a50a9a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into function_parameters_non_nullable

    @severn-everett
    severn-everett committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    0992e7d View commit details
    Browse the repository at this point in the history

  3. Address Detekt issues

    @severn-everett
    severn-everett committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    b642aa9 View commit details
    Browse the repository at this point in the history

  4. Added check to ignore override function; Added tests to improve code … 

    …coverage
    @severn-everett
    severn-everett committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    e5ecb4a View commit details
    Browse the repository at this point in the history

  5. Enabled nullable params to be passed through to non-local variables a… 

    …nd other functions
    @severn-everett
    severn-everett committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    b0a3cda View commit details
    Browse the repository at this point in the history

  6. Addressing Detekt issue

    @severn-everett
    severn-everett committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    82f5f85 View commit details
    Browse the repository at this point in the history

  7. Fixed Detekt issue

    @severn-everett
    severn-everett committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    2d48819 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Reworked CanBeNonNullable so that it only calls on a specific heurist… 

    …ic instead of "guilty until proven innocent" for nullable params; Fixed Detekt issue
    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    6a2bdc8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into function_parameters_non_nullable 

    # Conflicts:
#	detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/CanBeNonNullableSpec.kt
    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    408e7ec View commit details
    Browse the repository at this point in the history

  3. Fixed merge conflict

    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    a260193 View commit details
    Browse the repository at this point in the history

  4. CanBeNonNullable will only flag a param that has been checked for non… 

    …-null type if that check is the only expression in the function
    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    8a381b5 View commit details
    Browse the repository at this point in the history

  5. Added check for when a single-expression function finishes on a null-… 

    …safe extension function; Fixed Detekt issues in SplitPattern.kt
    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    d8aef95 View commit details
    Browse the repository at this point in the history

  6. Addressing Detekt issues in SplitPattern.kt

    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    e95d7ab View commit details
    Browse the repository at this point in the history

  7. Single expression check now recursively evaluates lambdas

    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    73790f1 View commit details
    Browse the repository at this point in the history

  8. Address Detekt issues

    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    b3445d9 View commit details
    Browse the repository at this point in the history

  9. CanBeNonNullable will now ignore params that are involved in an elvis… 

    … operator expression
    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    9d22662 View commit details
    Browse the repository at this point in the history

  10. CanBeNonNullable will now ignore single expression calls where the re… 

    …ceiver is not one of the nullable params
    @severn-everett
    severn-everett committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    c69f3c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Simplified checks for single-expression functions; Consolidated param… 

    … tests in CanBeNonNullableSpec.kt
    @severn-everett
    severn-everett committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    f9e938e View commit details
    Browse the repository at this point in the history

  2. Address Detekt issues

    @severn-everett
    severn-everett committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    08bc3fe View commit details
    Browse the repository at this point in the history

  3. Clean up CanBeNonNullableSpec tests

    @severn-everett
    severn-everett committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    9f07ecc View commit details
    Browse the repository at this point in the history

  4. Addressing PR comments

    @severn-everett
    severn-everett committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    9875284 View commit details
    Browse the repository at this point in the history