Ignore private operators when we don't have ContextBingding in UnusedPrivateMember #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4441 +/- ##
=========================================
Coverage 84.32% 84.33%
Complexity 3293 3293
=========================================
Files 472 472
Lines 10522 10525 +3
Branches 1885 1886 +1
=========================================
+ Hits 8873 8876 +3
Misses 671 671
Partials 978 978
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jan 2, 2022
...les-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMemberSpec.kt
Show resolved
Hide resolved
...t-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnusedPrivateMember.kt
Show resolved
Hide resolved
BraisGabin
force-pushed
the
fix-4242
branch
2 times, most recently
from
02e361f
to
56c7306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining mixed rules is really painful: #2994.
Note: the change seems big but I just added the
filterNoton the top. The problem is that with the reformat git thinks that all is new.fixes #4242
#4435 is related. This will fix the false positives without type solving. But we still have false positives with type solving.