Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HTML report css #4447

Merged

Conversation

JavierSegoviaCordoba
Copy link
Contributor

@JavierSegoviaCordoba JavierSegoviaCordoba commented Jan 3, 2022

The colors are based on detekt branding

And... an image is better than 1000 words:

image

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! What a change! Thanks!

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #4447 (8253490) into main (ff7824d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4447   +/-   ##
=========================================
  Coverage     84.32%   84.32%           
  Complexity     3293     3293           
=========================================
  Files           472      472           
  Lines         10522    10522           
  Branches       1885     1885           
=========================================
  Hits           8873     8873           
  Misses          671      671           
  Partials        978      978           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7824d...8253490. Read the comment docs.

@cortinico cortinico merged commit 4f8761f into detekt:main Jan 3, 2022
@cortinico
Copy link
Member

Great stuff! :) We should also think about exporting it to a custom CSS file so users can customize it as they wish.

@cortinico cortinico added this to the 1.20.0 milestone Jan 3, 2022
@cortinico cortinico added documentation notable changes Marker for notable changes in the changelog reports and removed documentation labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants